binance-trader icon indicating copy to clipboard operation
binance-trader copied to clipboard

Bot purchases and never sells

Open Jagermeister56 opened this issue 7 years ago β€’ 28 comments

Bot purchases and never even tries to sell. instead tries to keep buying more.

screen shot 2018-01-08 at 12 48 18 am

Jagermeister56 avatar Jan 08 '18 05:01 Jagermeister56

So i think you need buy some more BNB coin for trade fee. Or check your balance and make sure it enough for trade fee

linhndd avatar Jan 08 '18 13:01 linhndd

This was an issue I had, and I resolved it by buying more BNB as well.

001au avatar Jan 08 '18 13:01 001au

even with BNB this issue still seems to happen once every so often. it also continues to try buying over and over again. It is much more stable now, but still gets stuck every so often while being well above my profit parameters

1/7 times it'll get stuck so not too bad, i can live with that for now =)

Jagermeister56 avatar Jan 09 '18 04:01 Jagermeister56

Im Having the Same Issue With this the latest build.

On Mon, Jan 8, 2018 at 10:27 PM, Jagermeister56 [email protected] wrote:

even with BNB this issue still seems to happen once every so often. it also continues to try buying over and over again. It is much more stable now, but still gets stuck every so often while being well above my profit parameters

β€” You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/yasinkuyu/binance-trader/issues/66#issuecomment-356176710, or mute the thread https://github.com/notifications/unsubscribe-auth/AhX1kUB2SypS84ZCh4uH9a2QRXLM0uzNks5tIuqxgaJpZM4RV94s .

nealgentry avatar Jan 09 '18 07:01 nealgentry

Same, i own 3 BNB coin

VasTShadowZz avatar Jan 09 '18 07:01 VasTShadowZz

yes, i see that is problem. Bot always buy coin and never set sell. I think we need turn back version. I think it run stable. We need waiting for fix this version and test it again

linhndd avatar Jan 09 '18 10:01 linhndd

Do you need to pay fees with BNB?

jiqqaman avatar Jan 09 '18 16:01 jiqqaman

It’s in your Binance account settings. You can toggle it off.

001au avatar Jan 09 '18 16:01 001au

@001au How much BNB do you own for the error not to accure?

VasTShadowZz avatar Jan 09 '18 18:01 VasTShadowZz

I have BNB turned off in my settings because of the constant purchasing of coins .

I had .5 eth and after running the bot, i had zillions of coins, and no eth left... Just kept buying and buying . Never selling even when the price dropped.

Then I got the error of Insufficent Funds.... I didnt lose any $$ at all, my ETH balance just got spread around .

Is there any fix for the program to sell at some point?

MIKEYCRYPTO avatar Jan 09 '18 18:01 MIKEYCRYPTO

@MIKEYCRYPTO I stared small with just a test with the minimum, 0.0002BTC and it buys and sells like one or twice and then try to buy the 3rd time and then doesn't sell and trys to purchase again with the funds error.

VasTShadowZz avatar Jan 09 '18 18:01 VasTShadowZz

now it's buying and selling, but sometimes it decides to buy at market value and gets stuck trying to sell it. Using BNB for fees. So far working great.. Maybe disable the buy at market value?

Jagermeister56 avatar Jan 10 '18 00:01 Jagermeister56

@Jagermeister56 no, when I using BNB coin for fee, but it always buy and buy during my balance is lost of the BTC and show error.

linhndd avatar Jan 10 '18 03:01 linhndd

Is the stop loss feature working?

Can someone post something that they are actually using that is working ok?

Currently im running

Python trader.py --quantity XXX --XRPETH --profit 1.5 --stoploss 4 --orderid 0 --wait_time 3 --test_mode false --loop 0

Is this a correct format?

On Jan 9, 2018 10:26 PM, "linhndd" [email protected] wrote:

@Jagermeister56 https://github.com/jagermeister56 no, when I using BNB coin for fee, but it always buy and buy during my balance is lost of the BTC and show error.

β€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/yasinkuyu/binance-trader/issues/66#issuecomment-356489130, or mute the thread https://github.com/notifications/unsubscribe-auth/AhoxyKZgX4z5hCqHMlHGq1BXE-yUAHsxks5tJC3TgaJpZM4RV94s .

MIKEYCRYPTO avatar Jan 10 '18 03:01 MIKEYCRYPTO

@MIKEYCRYPTO Eg: python trader.py --quantity 10 --symbol XRPETH --profit 1.5

It enough

linhndd avatar Jan 10 '18 04:01 linhndd

20180109_235312 20180109_235328 20180109_235435 1

All sorts of errors tonight after downloading the new build.

This is what i got after about 40 minutes running 3 windows.

MIKEYCRYPTO avatar Jan 10 '18 05:01 MIKEYCRYPTO

@MIKEYCRYPTO MIN_NOTIONAL usually means you don't meet the minimum requirement for the purchase. and all that code i have no idea, probably because you're trying to put a quantity under a full number for example: buying .3BTC with ETH at least i always get a bunch of errors when i try that Also i don't believe the --stop_loss function works yet according to what it says in trader.py

Jagermeister56 avatar Jan 10 '18 22:01 Jagermeister56

@linhndd i'm also had the same problem, try to update the entire program mine is even worse now, it waits until the worst time and decides to buy it at market price because it can't keep up. THEN i'm stuck with a ton of currency crashing down. i wouldn't use this until he does a few more updates if you're worried about losing money.

Jagermeister56 avatar Jan 10 '18 22:01 Jagermeister56

Yes, --stop_loss is the feature function. @yasinkuyu is prepare for next version. But I think he need fix problem is not sell and always buy coin

linhndd avatar Jan 11 '18 01:01 linhndd

Hi, i have a question ? After buy coin, how long it will be sell ? I see my bot running, it's always buy, and I waiting for sell, but it not work

linhndd avatar Jan 11 '18 03:01 linhndd

@linhndd once parameters will achieve settings that you set

idoo avatar Jan 11 '18 09:01 idoo

Same thing. Am I doing something wrong or is it an issue? It will buy but never sells.

gutch1 avatar Jan 11 '18 14:01 gutch1

Devx branch made some improvements. Not tested. https://github.com/yasinkuyu/binance-trader/commits/devx

yasinkuyu avatar Jan 13 '18 04:01 yasinkuyu

@linhndd Absolutely. --stop_loss is not ready yet.

yasinkuyu avatar Jan 13 '18 04:01 yasinkuyu

@Jagermeister56 MIN_NOTIONAL error has been fixed.

yasinkuyu avatar Jan 13 '18 04:01 yasinkuyu

Great, I will be test it and feedback for you if have problem :)

linhndd avatar Jan 13 '18 05:01 linhndd

Thank you for the updates. We really appreciate your effort. I just tested devx branch and:

33

det-peralta avatar Jan 13 '18 12:01 det-peralta

Hi,

Thanks for this great job Yasin.

I have the same problem when I don't have enough BTC to buy an other coin, so may be in the code you can create an order sell if there is not enough BTC and just don't buy anymore until there is more BTC?

Thanks

Memoi avatar Jan 15 '18 08:01 Memoi