selene icon indicating copy to clipboard operation
selene copied to clipboard

browser.close_current_tab or browser.close_current_window alias for browser.close() ?

Open yashaka opened this issue 8 years ago • 2 comments

relates to #101 read its comments to understand the point...

yashaka avatar Mar 01 '17 00:03 yashaka

  1. What about just to add a doc string for this function? And leave users to read the manual.
  2. And what's the problem to add a doc string for another one - "quit()" function too.

So those users, who would use imports directly - could read the doc string and understand what "quit" method means in context.

aleksandr-kotlyar avatar Jul 14 '19 14:07 aleksandr-kotlyar

Selene is kind of "test as humans use"-tool, not "as driver operates"-tools. That's why I prefer more user-oriented naming, to make tests code as much readable and obvious as possible. Readability is very important in tests:)

Yet... Maybe specifically with these commands - it will be too much... And it would be better to keep names as "close" and "quit"... Let's see...

yashaka avatar Jul 14 '19 20:07 yashaka