Tidal-Media-Downloader-PRO icon indicating copy to clipboard operation
Tidal-Media-Downloader-PRO copied to clipboard

Published 20 hours ago • verified publisher icon yaronzz

TrackNumber - specify number of leading 0's

Open t0l0 opened this issue 4 years ago • 4 comments

Thank you for this incredibly useful tool.

When it comes to audio books the single leading 0 that the tool is currently adding to single-digit track numbers is unfortunately not enough to keep up with the number of tracks (100s). Would you consider either switching to three digits or making the number of digits configurable, so I would end up with something like

001 - Track 1.mp4 ... 241 - Track 241.mp4

?

For now I can work around this only with external tools to rename files after they have been downloaded completely.

Thanks and Best, t0l0

t0l0 avatar Jan 06 '21 13:01 t0l0

This issue has been automatically marked as stale because it has not had recent activity.

github-actions[bot] avatar May 25 '22 15:05 github-actions[bot]

Ping, so it's not marked as stale.

t0l0 avatar May 25 '22 18:05 t0l0

This issue has been automatically marked as stale because it has not had recent activity.

github-actions[bot] avatar Jul 26 '22 15:07 github-actions[bot]

Ping

t0l0 avatar Aug 02 '22 12:08 t0l0

@t0l0 can you give me detailed steps to reproduce and see the problem?

MozgC avatar Sep 26 '22 04:09 MozgC

image

@MozgC If you download any album (probably applies to playlists, too) with > 99 tracks, you run into this issue. Track numbers currently are only zero-padded to a length of 2.

The numbering currently is 01 02 … 09 10 which is fine.

From Track 98 on, it is 98 99 100 101 102 which results in sorting problems under some OS/FS.

Try this random audiobook as an example: https://listen.tidal.com/album/197503724

I think it should be enough to change padding length to 3 in these 2 places, ideally optionally make it configurable for people who do not want a 3-length padding.

https://github.com/yaronzz/Tidal-Media-Downloader-PRO/blob/74d7599aa1e12ac6c191009f5f68fb635187bb38/TIDALDL-UI-PRO/Else/Tools.cs#L130

https://github.com/yaronzz/Tidal-Media-Downloader-PRO/blob/74d7599aa1e12ac6c191009f5f68fb635187bb38/TIDALDL-UI-PRO/Else/Tools.cs#L132

Sorry for not submitting a pull request, I currently do not have a C# dev environment at hand.

t0l0 avatar Oct 28 '22 10:10 t0l0

@yaronzz Please merge the PR

MozgC avatar Dec 15 '22 03:12 MozgC

@t0l0 thanks for the explanation. The PR is ready.

MozgC avatar Dec 15 '22 03:12 MozgC

This issue has been automatically marked as stale because it has not had recent activity.

github-actions[bot] avatar Feb 13 '23 15:02 github-actions[bot]