yaronvel

Results 13 comments of yaronvel

digging further into the issue, it seems there is a performance issue in getEstimateGas with ganache fork. And if i do one voodo operation (an arbitrary contract write), then getEstimateGas...

Item 3 is applicable only if `submitClaim` tx is stuck. If `verifyClaim` tx stuck you cannot resubmit them. Also: 4. In mainnet, retransmit from

added a PR with a basic test for `rpow`. https://github.com/makerdao/dss/pull/145

“Beware of bugs in the above code; I have only proved it correct, not tried it.” ― Donald Knuth But on a more serious note, i guess klab and dapp...

I will work on it. Note that most statstic will be gathered by a javascript client/webpage. I will added minimal needed support in the contract (events) and make a javascript...

Hi, thanks for changing the branch. But still, can you explain why this change is needed? why should we support addresses longer than 20 bytes?

Should probably reset old wallet allowance in this case. And also reset allowance to reserve in case it was non zero before. More generally if u want to change it,...

this https://github.com/KyberNetwork/smart-contracts/blob/master/contracts/LiquidityConversionRates.sol#L201 When price goes below min rate for buy it will typically also go over max rate for sell. In principle it usually happens when inventory of one side...

I would strongly recommend to reconsider. You think you have 128 bits security, where in fact you have 64 bits security. It would take only `2^64` attempts to generate a...

Idk if pub keys are uniformly distributed, would guess yes. But anw, with create2 it is a matter of finding two smart contracts with 16 bytes collision in their address....