xml-crypto icon indicating copy to clipboard operation
xml-crypto copied to clipboard

If first reference matches a special case, other references are not validated

Open thoro opened this issue 6 years ago • 1 comments

Please see the following return:

https://github.com/yaronn/xml-crypto/blob/4d72940b0f0ada3a87468265b34768e8f77fd737/lib/signed-xml.js#L501

should not be there and should be replaced by a continue;

Actually, the whole if can be removed, since there's a second hash check afterwards ....

thoro avatar Feb 25 '19 16:02 thoro

@Thoro , if you have a suggestion for improvement, please considering creating a PR with a test suite so that we can review the change and get it incorporated so that the entire community can benefit from your efforts.

cjbarth avatar May 29 '23 21:05 cjbarth