blessed-contrib icon indicating copy to clipboard operation
blessed-contrib copied to clipboard

`4.11.0` leads to `node:process` not found

Open schw4rzlicht opened this issue 2 years ago • 6 comments

Hey there,

when upgrading from 4.10.1 to 4.11.0, we get following error:

Error: Cannot find module 'node:process'
Require stack:
- /Users/[...]/node_modules/marked-terminal/index.cjs
- /Users/[...]/node_modules/blessed-contrib/lib/widget/markdown.js
- /Users/[...]/node_modules/blessed-contrib/index.js
- /Users/[...]/src/commands/start/ui/index.ts
- /Users/[...]/src/commands/start/index.ts
- /Users/[...]/src/index.ts
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:885:15)
    at Function.Module._resolveFilename.sharedData.moduleResolveFilenameHook.installedValue [as _resolveFilename] (/Users/[...]/node_modules/@cspotcode/source-map-support/source-map-support.js:679:30)
    at Function.Module._load (internal/modules/cjs/loader.js:730:27)
    at Module.require (internal/modules/cjs/loader.js:957:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at Object.<anonymous> (/Users/[...]/node_modules/marked-terminal/index.cjs:3:17)
    at Module._compile (internal/modules/cjs/loader.js:1068:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1097:10)
    at Module.load (internal/modules/cjs/loader.js:933:32)
    at Function.Module._load (internal/modules/cjs/loader.js:774:14) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/[...]/node_modules/marked-terminal/index.cjs',
    '/Users/[...]/node_modules/blessed-contrib/lib/widget/markdown.js',
    '/Users/[...]/node_modules/blessed-contrib/index.js',
    '/Users/[...]/src/commands/start/ui/index.ts',
    '/Users/[...]/src/commands/start/index.ts',
    '/Users/[...]/src/index.ts'
  ]
}

What can we do about it?

schw4rzlicht avatar May 04 '22 09:05 schw4rzlicht

yes, it does

archoak avatar May 06 '22 04:05 archoak

@schw4rzlicht @oo-long - which node versions are you running on?

lirantal avatar May 08 '22 18:05 lirantal

@lirantal 14.16.0 for me, same issue

y4my4my4m avatar May 11 '22 10:05 y4my4my4m

Could you try with the latest Node.js LTS (version 14.19.2) and let me know if it persists? Might be related to a newer version of marked that's causing it.

lirantal avatar May 11 '22 12:05 lirantal

@lirantal indeed node 14.19.3 fixes it for me. Do we want to close this issue here then?

schw4rzlicht avatar Jun 03 '22 17:06 schw4rzlicht

Yes will do. I think we can update the docs about that and leave it at that.

lirantal avatar Jun 08 '22 18:06 lirantal