blessed-contrib icon indicating copy to clipboard operation
blessed-contrib copied to clipboard

[Feature request] Use kenan238/reblessed

Open KaKi87 opened this issue 4 years ago • 15 comments

Hello,

As blessed hasn't been updated since 01/2016, I'm suggesting that blessed-contrib uses neo-blessed, which is the only currently maintained fork.

Thanks

KaKi87 avatar May 15 '20 11:05 KaKi87

Why hasn't this or discussion around it happened yet?

dustinlacewell avatar Jul 07 '21 20:07 dustinlacewell

Well, turns out even neo-blessed is also dead anyway.

We need a new maintainer.

Although I'm not expecting anyone to volunteer 🙁

KaKi87 avatar Jul 08 '21 07:07 KaKi87

Hi folks 👋🏼

@yaronn is the original author and maintainer of this library, but I have stepped up to actively maintain the small bits of updates of dependency updates and simple pull requests that I could test and ensure aren't breaking anything.

Indeed the original blessed package isn't maintained anymore, and I'm happy to explore the option of working based off of the new fork.

If there are more actionable steps I can take, or we'd like to bring up, I'm happy to participate and help as needed.

lirantal avatar Jul 08 '21 15:07 lirantal

What would be the actionable steps beyond just changing the dependency and updating the readme?

dustinlacewell avatar Jul 08 '21 17:07 dustinlacewell

No idea, that's why I was asking. However, I'm not keen on simply replacing one outdated/unmaintained library with another.

lirantal avatar Jul 08 '21 17:07 lirantal

Hello, the currently active blessed fork is now kenan238/reblessed, therefore I renamed the issue accordingly. Thanks

KaKi87 avatar Feb 20 '22 18:02 KaKi87

@KaKi87 has there been any significant changes introduced in reblessed ?

lirantal avatar Feb 20 '22 19:02 lirantal

I didn't checked, but at least the maintainer replies.

KaKi87 avatar Feb 20 '22 23:02 KaKi87

Hello, reblessed's maintainer replies and fixes issues, I really think it should be the recommended fork by now.

KaKi87 avatar May 14 '22 11:05 KaKi87

Hi!

I have been searching for a discussion like this, as I was making a JSX addon to blessed forks. I have created an issue in reblessed's repo about adding TS type definitions or rewriting the package to TS, but didn't get an answer. The last commit to master is from 4 months ago, too.

I would be cool to collaborate with someone to fix up the reblessed package and maybe re-publish it, and gather people using different forks into a central repository, as I have encountered a bunch of bugs in blessed, neo-blessed and reblessed.

michalusio avatar Oct 27 '22 00:10 michalusio

I have created an issue in reblessed's repo about adding TS type definitions or rewriting the package to TS, but didn't get an answer. The last commit to master is from 4 months ago, too.

The maintainer is a student living in a country experiencing stability issues. He is aware of your issue and will reply to it although he didn't have time to do it yet.

I would be cool to collaborate with someone to fix up the reblessed package and maybe re-publish it, and gather people using different forks into a central repository, as I have encountered a bunch of bugs in blessed, neo-blessed and reblessed.

Personally, I would encourage making reblessed the primary repo and collaborating to it.

KaKi87 avatar Oct 27 '22 16:10 KaKi87

@KaKi87 As the maintainer won't probably have enough time to merge PRs to reblessed (certainly not ones like adding strict typing and refactors they could entail) I will create a temporary fork and use that for my project - thanks for replying!

michalusio avatar Oct 27 '22 18:10 michalusio

Hello, maintainer of reblessed here, reblessed is not dead at all, about the TS support, I'm still thinking about, I'll maybe make a branch to port it to typescript. The issue for me is my unstable country where I have limited power and Internet per day, but I'm doing my best ;). I'm pretty much in the cleanup phase of reblessed right now where I try and fix up some old javascript habits such as the function-classes.

kenan238 avatar Jan 23 '23 15:01 kenan238

+1 typescript

dustinlacewell avatar Jan 23 '23 17:01 dustinlacewell

@KaKi87 As the maintainer won't probably have enough time to merge PRs to reblessed (certainly not ones like adding strict typing and refactors they could entail) I will create a temporary fork and use that for my project - thanks for replying!

@michalusio Oh hello! I've already started the refactoring phase, you can still create PRs, I'll merge them early hopefully since I have github mobile that gives me notifications on new PRs, and I have more access to my phone than PC.

kenan238 avatar Feb 12 '23 16:02 kenan238