website icon indicating copy to clipboard operation
website copied to clipboard

Less bold security claims

Open vog opened this issue 6 years ago • 4 comments

The strong security claims convey a wrong impression of the actual state of the project:

  • SHA-1 hashes are used even though SHA-1 is considered deprecated for quite a long time.
  • Files are partly processed before the checksum is verified (namely, it is unpacked), violating security best practices and making Yarn unnecessarily vulnerable to exploits for tar, gzip, etc., as well as zip bombs.
  • The number of volunteers is too small to react quickly on those issues: The SHA-1 issue is open for 1.5 years, the verification issue is open for 0.5 years.

This all isn't bad in itself. Yarn does most things right and is nevertheless a really strong competitor to NPM. But the website should be honest on that upfront, instead of giving a false sense of security.

vog avatar May 23 '18 05:05 vog

Deploy preview for yarnpkg ready!

Built with commit 01dee4133965fb55809def293117de2392aeae43

https://deploy-preview-823--yarnpkg.netlify.com

Haroenv avatar May 23 '18 05:05 Haroenv

Thinking more about this, you might want to switch the order of items, such that "Reliable" is above "Security".

vog avatar May 23 '18 06:05 vog

The SHA-1 issue is open for 1.5 years

I think that's being addressed in https://github.com/yarnpkg/yarn/pull/5042?

Daniel15 avatar May 23 '18 06:05 Daniel15

@Daniel15 I'm aware of this progress and I'm glad that at least one of the issues will probably be fixed over the next days.

But there's still the unpacking issue (0.5 years old, and being downplayed as a not-so-critical security issue). And it is not clear how fast future security issues will be fixed.

Which, again, isn't that bad for a volunteer project with limited resources. But it is a problem for a project that makes bold security claims.

So in the end, this just means that the website should have been adjusted 1.5 years ago. And should not be changed back until all security issues have finally been solved.

I have been asked in https://github.com/yarnpkg/yarn/issues/4638 to make a proposal for a better wording on the website, and this pull request is what I came up with.

vog avatar May 23 '18 13:05 vog