berry icon indicating copy to clipboard operation
berry copied to clipboard

fix(plugin-npm): add resolver for converting locators with __archiveUrl

Open BasixKOR opened this issue 1 year ago • 1 comments

What's the problem this PR addresses?

PatchResolver assumes every source locator it has will work as a descriptor too, but it is not a case with npm: locators with __archiveUrl added.

As a result, when you patch a package with __archiveUrl appended, it will not work because there are no resolvers handling descriptors with __archiveUrl.

Fixes #4711. ...

How did you fix it?

This PR adds a stub implementation for resolving descriptors with __archiveUrl and just converting them into locators.

...

Checklist

  • [x] I have set the packages that need to be released for my changes to be effective.
  • [x] I will check that all automated PR checks pass before the PR gets reviewed.

BasixKOR avatar Sep 26 '24 19:09 BasixKOR

Can you look to add a test? You can use the unconventional-tarball package from within the tests to get a package that generates an __archiveUrl locator.

arcanis avatar Oct 01 '24 14:10 arcanis

Superseded by #6891.

BasixKOR avatar Sep 08 '25 03:09 BasixKOR