berry icon indicating copy to clipboard operation
berry copied to clipboard

Fix CRA E2E test

Open clemyan opened this issue 1 year ago • 1 comments

What's the problem this PR addresses?

The CRA E2E test has been failing. CRA only supports ESLint up to v8

How did you fix it?

Stop installing eslint ourselves -- react-scripts depends on it already.

As far as I can tell, eslint-config-react-app also don't need to be installed explicitly now

Checklist

  • [x] I have set the packages that need to be released for my changes to be effective.
  • [x] I will check that all automated PR checks pass before the PR gets reviewed.

clemyan avatar Jul 30 '24 16:07 clemyan

Great that we don't need to install those ourselves anymore, we had to install both before (ref https://github.com/yarnpkg/berry/pull/3988). We should remove it from https://github.com/yarnpkg/berry/blob/9b7b745fb6eb928e909df23200d9860f8803f836/.github/workflows/e2e-storybook-workflow.yml#L32-L33 and https://github.com/yarnpkg/berry/blob/9b7b745fb6eb928e909df23200d9860f8803f836/.github/workflows/e2e-cra-workflow.yml#L41-L42 as well.

I wanted to check when it was fixed but that's apparently not allowed.

$ yarn dlx [email protected] my-cra
You are running `create-react-app` 5.0.0, which is behind the latest release (5.0.1).

We no longer support global installation of Create React App.

merceyz avatar Jul 30 '24 17:07 merceyz

I removed the E2E CRA since it's now officially deprecated.

arcanis avatar Feb 17 '25 10:02 arcanis