[Bug?]: Patch isn't applying fully to @rnmapbox/maps
Self-service
- [ ] I'd be willing to implement a fix
Describe the bug
yarn add @rnmapbox/maps
yarn patch @rnmapbox/maps
cd [tmp folder]
npm i -g typescript
npx tsc --declaration false --noImplicitAny false
cd -
yarn patch-commit -s [tmp folder]
This will create a patch that for some reason adds a b directory instead of the lib directory thats added from typescript. Further, if you make any changes to package.json before patch-commit, those are entirely lost.
To reproduce
yarn add @rnmapbox/maps
yarn patch @rnmapbox/maps
cd [tmp folder]
npm i -g typescript
npx tsc --declaration false --noImplicitAny false
cd -
yarn patch-commit -s [tmp folder]
This will create a patch that for some reason adds a b directory instead of the lib directory thats added from typescript. Further, if you make any changes to package.json before patch-commit, those are entirely lost.
Environment
System:
OS: macOS 12.5.1
CPU: (8) arm64 Apple M2
Binaries:
Node: 16.14.0 - /private/var/folders/w3/nl3nl7ks6s36641hzl_gls9m0000gn/T/xfs-f997a031/node
Yarn: 3.1.1 - /private/var/folders/w3/nl3nl7ks6s36641hzl_gls9m0000gn/T/xfs-f997a031/yarn
npm: 8.15.0 - ~/Library/Caches/fnm_multishells/69747_1653603955297/bin/npm
Additional context
No response
I tried to reproduce (Docker container, node:latest tag, Yarn 3.2.3), and it seems to have worked just fine for me, it generated the following patch (had to zip it because GH wouldn't allow me to upload a .patch file):
Hi! 👋
This issue looks stale, and doesn't feature the reproducible label - which implies that you didn't provide a working reproduction using Sherlock. As a result, it'll be closed in a few days unless a maintainer explicitly vouches for it or you edit your first post to include a formal reproduction (you can use the playground for that).
Note that we require Sherlock reproductions for long-lived issues (rather than standalone git repositories or similar) because we're a small team. Sherlock gives us the ability to check which bugs are still affecting the master branch at any given point, and decreases the amount of code we need to run on our own machines (thus leading to faster bug resolutions). It helps us help you! 😃
If you absolutely cannot reproduce a bug on Sherlock (for example because it's a Windows-only issue), a maintainer will have to manually add the upholded label. Thanks for helping us triaging our repository! 🌟