berry icon indicating copy to clipboard operation
berry copied to clipboard

cache reset

Open goloveychuk opened this issue 3 years ago • 1 comments

What's the problem this PR addresses? fixes #4673 ...

Checklist

  • [ ] I have set the packages that need to be released for my changes to be effective.
  • [x] I will check that all automated PR checks pass before the PR gets reviewed.

goloveychuk avatar Aug 08 '22 11:08 goloveychuk

@arcanis From my side, pr is ready. The question is if it's correct behavior.

goloveychuk avatar Aug 25 '22 16:08 goloveychuk

@arcanis can we merge it, if I'll remove CI default = reset?

goloveychuk avatar Oct 21 '22 10:10 goloveychuk

idk how to fix versioning issue,

node ./scripts/run-yarn.js version check -i
Usage Error: Your current branch contains multiple versioning files; this isn't supported:

and it's tens of files..

goloveychuk avatar Oct 21 '22 15:10 goloveychuk

Your master branch is out of date so when Yarn diffs this branch against your master branch it looks like there is a bunch of version files added. I've set the versions for you.

merceyz avatar Oct 21 '22 16:10 merceyz

Green

goloveychuk avatar Oct 21 '22 18:10 goloveychuk

Can we merge it?

goloveychuk avatar Oct 25 '22 13:10 goloveychuk

Yep! Thanks for your help! 😊

arcanis avatar Oct 25 '22 13:10 arcanis

@arcanis hey, I've just downloaded today's release, and this pr is not there. Maybe it should be merged into other branch? image

goloveychuk avatar Feb 02 '23 09:02 goloveychuk

This PR wasn't backported to v3, I've backported it now so it will be in the next v3 release, until then you can use the v4 canary if you want.

yarn set version canary

merceyz avatar Feb 02 '23 10:02 merceyz