berry
berry copied to clipboard
yarnpkg
docs: add `better-optional` to contrib plugins
What's the problem this PR addresses?
Workaround for issue #4306.
...
How did you fix it?
Providing a better-optional plugin, that allows "installation" of packages that do not exist in the package registry.
...
Checklist
- [x] I have read the Contributing Guide.
- [x] I have set the packages that need to be released for my changes to be effective.
- [x] I will check that all automated PR checks pass before the PR gets reviewed.
While the plugin itself is fine, I feel like its name ("better-optional") might not be the best. The default behavior is there for a reason, and while it's ok you want something different, it doesn't make it "better" - merely different. Before we merge this PR, I'd appreciate if the plugin could be renamed into something perhaps a little clearer (optional-resolution?).
(This isn't just about pretty name - putting myself in the shoes of a junior developer, I could see myself be thoroughly confused if I saw a "better-something" plugin, thinking I really need to install it even if I don't actually need it)
Hey @arcanis sure, really appreciate your feedback! 🙂 "better-optional" was chosen mostly because it sounded catchy, but I fully understand your concerns.
Let me brainstorm for "better" (😝) name and I'll get back to you shortly.
Sorry @arcanis and @RDIL I got severely side-tracked. I finally managed to rename the plugin as you suggested @arcanis. I also rebased my commit onto the lastest master. Please feel free to provide any feedback. Thanks.