berry icon indicating copy to clipboard operation
berry copied to clipboard

feat: install git repositories that use pnpm

Open paul-soporan opened this issue 2 years ago • 3 comments

What's the problem this PR addresses?

We don't currently support installing git repositories that use pnpm.

Fixes https://github.com/yarnpkg/berry/issues/3169

How did you fix it?

Added support for installing git repositories that use pnpm; workspaces are supported too.

Checklist

  • [X] I have set the packages that need to be released for my changes to be effective.
  • [X] I will check that all automated PR checks pass before the PR gets reviewed.

paul-soporan avatar Oct 22 '21 19:10 paul-soporan

Any chance this could be in the next canary release? Just to be clear, this isn't just for dependencies that themselves use PNP? I can't use a branch of Vite for instance, and afaik they aren't using Yarn Berry.

seivan avatar Jul 07 '22 15:07 seivan

This PR makes Yarn able to install any git: dependency that uses pnpm.

Any chance this could be in the next canary release?

Most likely yes, I originally put it on hold because it required a fix inside corepack so that our tests would pass, but now it should be possible to rebase and make everything work. I'll look into it.

paul-soporan avatar Jul 07 '22 15:07 paul-soporan

Most likely yes, I originally put it on hold because it required a fix inside corepack so that our tests would pass, but now it should be possible to rebase and make everything work. I'll look into it.

Great, thanks!

This PR makes Yarn able to install any git: dependency that uses pnpm.

Are you saying that the dependency itself is built with pnpm or the project that refers to the git dependency is pnpm?

I'm the latter for instance, I got a dependency, I wanna try out a fork. The dependency isn't even using yarn. Would this work?

seivan avatar Jul 07 '22 15:07 seivan