AccessSniff Replace phantomjs

Since phantom-js is no longer maintained, perhaps jsdom could be used?

Aug 05 '17 11:08 XhmikosR

I should have checked the source first. Since jsdom is there, I'd suggest that is completely removed; too much overhead and jsdom seems to work fine.

Aug 05 '17 11:08 XhmikosR

Hmm, now I remember... With browser: false thus using jsdom, testing is super slow at least on my Windows system.

Aug 05 '17 12:08 XhmikosR

@yargalot i think phantom js should be removed completely because its bloating the node_modules folder by ~60MB.

Oct 24 '17 22:10 axten

We could also remove PhantomJS and use Puppeteer along with Chrome Headless. I could help with a PR here is that sounds like a good solution.

Feb 09 '18 16:02 gamebox

Yeh makes sense to replace phantom with puppeteer. Happy to take that as a pull request

Feb 09 '18 16:02 yargalot

Awesome, I'll work on that and submit when I get a chance

Feb 09 '18 16:02 gamebox

any updates here?

Jun 07 '18 11:06 axten