PcbDraw icon indicating copy to clipboard operation
PcbDraw copied to clipboard

[Suggestion] Eliminate engineering_number dependency

Open set-soft opened this issue 3 years ago • 1 comments

I see that 7b2a4b9bcc7c76ca689cb616563cccfed851612c introduced a new dependency engineering_number.

I think you should avoid it using something like: https://github.com/INTI-CMNB/PcbDraw/commit/74ccf4bd56f37c8f6a03f1b588014146afbde5a5

Which is a poor as engineering_number but solves the problem in 8 LOCs instead of pulling a new dependency.

As you are undergoing a major rewrite I'll suggest taking a look at https://github.com/INTI-CMNB/KiBot/blob/master/kibot/bom/units.py This code comes from KiBoM and I think iBoM also uses it. It handle things like 1k5 or 1 meg

set-soft avatar Jun 24 '22 13:06 set-soft

I agree with this and I will address this.

yaqwsx avatar Jun 26 '22 19:06 yaqwsx

Removed in 2635a07b12af3041f2b15d557bd3d780091bc7fa. It was replaced by a code from https://github.com/yaqwsx/jlcparts.

yaqwsx avatar Sep 22 '22 07:09 yaqwsx