PcbDraw icon indicating copy to clipboard operation
PcbDraw copied to clipboard

Support mistune >= 2.0.0

Open dvzrv opened this issue 2 years ago • 6 comments

Hi! This project is packaged on Arch Linux and we would like to be able to get rid of our python-mistune1 package (which ships mistune < 2.0.0).

It would be awesome if pcbdraw could work with current mistune (https://pypi.org/project/mistune/) which is >= 2.0.0 as that would allow us to move on :)

dvzrv avatar Aug 29 '22 08:08 dvzrv

Hi, I can arrange that with the upcoming v1 release. I cannot promise you any deadline, though. If you would like to speed this up, you can submit a PR.

yaqwsx avatar Aug 29 '22 08:08 yaqwsx

I agree with this, if I'm also willing to help if I get time

pintert3 avatar Sep 01 '22 10:09 pintert3

@yaqwsx Thanks. As I have no idea how your codebase works and the renderer code seems pretty custom, I don't think I have the time to spend on this unfortunately. It doesn't look overly complex though, so if @pintert3 or anyone else is up for the task, that'd be awesome! :)

dvzrv avatar Sep 03 '22 08:09 dvzrv

Just a note: the only place where mistune is used is in the populate functionality located in https://github.com/yaqwsx/PcbDraw/blob/master/pcbdraw/populate.py

What we do is we add a new tag into the markdown parser - the one that renders a board with new components added.

yaqwsx avatar Sep 05 '22 06:09 yaqwsx

Thanks, that'll help a lot

pintert3 avatar Sep 06 '22 00:09 pintert3

I merged the PR. I will take a week or two for final testing, and then I will release version 1.0.0 of PcbDraw.

yaqwsx avatar Sep 11 '22 20:09 yaqwsx

v1 was released, closing.

yaqwsx avatar Sep 22 '22 17:09 yaqwsx