PcbDraw-Lib icon indicating copy to clipboard operation
PcbDraw-Lib copied to clipboard

THT Resistor Bands and Vertical

Open Electro707 opened this issue 1 year ago • 3 comments

This PR adds a 5-color code bands and a zero/short band to the existing horizontal through-hole resistor models. The 5-color bands or the zero band is displayed by my fork of PCBdraw, see https://github.com/yaqwsx/PcbDraw/pull/156

This change is meant to be backwards compatible with the current implementation of coloring in pcbdraw.

This PR also adds some more resistor sizes, after checking that they are indeed the "bean" type in KiCAD. Proportions are off, so I need to fix that (perhaps even make a new template for those larger sizes)

This PR also adds vertical resistors.

Latest image: image

TODO:

  • [ ] Change the larger size resistors to not look odd, perhaps make a new template for them

Electro707 avatar Jan 01 '24 02:01 Electro707

image

I think this looks slightly better. Thoughts on improvement? (especially for the taller large ones)

Electro707 avatar Jan 24 '24 01:01 Electro707

I think they look OK. One proposal - maybe adding a gradient to a darker color on one side or a thicker outline could increase the contrast between PCB and the resistor. Especially the resistors without the bands seem to blend with the PCB.

yaqwsx avatar Jan 30 '24 06:01 yaqwsx