ember-modal-dialog

ember-modal-dialog copied to clipboard

Acceptance tests with ember-tether

13

I would like to clarify what the best practices are around acceptance tests with `ember-tether`. When I write a basic `ember-modal-dialog` acceptance test that launches a modal, makes an assertion...

john-griffin

Add Proper ARIA Roles

1

This addon should really use the [`role="alertdialog"`](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_alertdialog_role) assertive role for screen readers. All we have to do is add corresponding `attributeBindings` and `role: 'alertdialog'` on the component. Also, [as the...

srsgores

Fixes issue #225 in real world app

BryanCrotaz

BryanCrotaz

Support close on mouseleave for tether dialog

1

Hello, Thanks for putting together a super-useful addon that tackles a really hard problem. I recently had a `tether-dialog` modal that I wanted to have close on `mouseleave` events, so...

BrianSipple

which fails [this line](https://github.com/yapplabs/ember-modal-dialog/blob/master/addon/components/modal-dialog.js#L26). Need to add test for default value of `animatable` & fix.

samselikoff

Access to `navigator` in module scope crashes Fastboot

1

Regression introduced in `4.1.3`. Rendering a modal in a Fastboot application will crash the server: ``` const isIOS = /iPad|iPhone|iPod/.test(navigator.userAgent); ^ ReferenceError: navigator is not defined ``` Code here: https://github.com/yapplabs/ember-modal-dialog/commit/65a84d58a99c75540d77cef21d59f578fa3d0f19#diff-e6e71d63dfb8f6989d87cbf93a6109a03917d85d083f2c11044875be495753deR14...

gilest

4.1.3 - need to wait until modal overlay is opened (in test)

1

This is more an advisory to others in case it affects them. I was confused why one of my tests was failing under 4.1.3 (it had no release notes to...

Techn1x

Bumps [webpack](https://github.com/webpack/webpack) from 5.67.0 to 5.76.0. Release notes Sourced from webpack's releases. v5.76.0 Bugfixes Avoid cross-realm object access by @​Jack-Works in webpack/webpack#16500 Improve hash performance via conditional initialization by @​lvivski...

dependabot[bot]

Bumps [minimist](https://github.com/minimistjs/minimist) from 0.2.1 to 0.2.4. Changelog Sourced from minimist's changelog. v0.2.4 - 2023-02-24 Commits [Tests] check side-effects of pollution protection 3dbebff [Robustness] rework isConstructorOrProto 34e20b8 [Dev Deps] update tape...

dependabot[bot]