ember-modal-dialog

ember-modal-dialog copied to clipboard

Bumps [parse-url](https://github.com/IonicaBizau/parse-url) from 6.0.0 to 6.0.5. Commits See full diff in compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter...

dependabot[bot]

Bumps [terser](https://github.com/terser/terser) from 4.8.0 to 4.8.1. Changelog Sourced from terser's changelog. v4.8.1 (backport) Security fix for RegExps that should not be evaluated (regexp DDOS) Commits See full diff in compare...

dependabot[bot]

Convert to v2 addon

2

- [x] Convert liquid-fire, liquid-tether, liquid-wormhole to optional peer deps - [ ] Add additional test apps to test with different combinations of these optional dependencies (move some existing tests...

lukemelia

When installing dependencies for my project, one of which depends on `ember-modal-dialog`, I see the following output in the logs. ` npm WARN tarball tarball data for ember-modal-dialog@git+ssh://[email protected]/yapplabs/ember-modal-dialog.git (sha512-eWhtEPQJQtuhJ4sFaiXSP1KiaNl+ywyDGoaUKpY45OFxsQurXgSLBxAizPBkjSXxmI0eJLHIDoRhbYHq4R4qVQ==) seems...

csprocket777

Exception: cannot update computed class names

3

*Using it the first time works.* Trying to update computed class names results in an exception being thrown: ``` TypeError: this.get(...).join is not a function at Class. (modal-dialog.js:17) at ComputedPropertyPrototype.get...

tsteuwer

With Ember 3.26 and ember-modal-dialog i get this error trying to open the dialog `Uncaught (in promise) TypeError: this.overlayClassNames?.join is not a function at BasicDialog.get overlayClassNamesString (basic-dialog.js:59:1) at index.js:1936:1 at...

Thomasevano

https://github.com/embroider-build/embroider/blob/main/PORTING-ADDONS-TO-V2.md Use [optional peer dependencies](https://emberjs.github.io/rfcs/0507-embroider-v2-package-format.html#peer-dependencies) for ember-tether, liquid-fire, liquid-tether, and liquid-wormhole.

lukemelia

Modal is closed when the click event is started inside the modal and ended on overlay

6

In our Ember application, we use ember-modal-dialog. Inside one of the modals, we have a slider control. If the user starts to click in the modal content and ends the...

rnuyts

Ember v3.27: Exception on Ember.computed.reads (liquid-wormhole)

4

After upgrade to Ember 3.27, I got error like this and the modal is not showing, it's related to the `liquid-*` packages: ``` Uncaught TypeError: Ember.computed.reads is not a function...

ptgamr

`transform: translate(-50%, -50%);` causing Text Blur

11

The modal is positioned using `transform: translate(-50%, -50%);` but it causes elements in the modal to be blurred: Element in modal with transform:  Element in...

mhluska