nginx_syslog_patch icon indicating copy to clipboard operation
nginx_syslog_patch copied to clipboard

Published 20 hours ago • verified publisher icon yaoweibin

NGINX 1.5

Open splitice opened this issue 11 years ago • 11 comments

src/core/ngx_log.c:699:27: error: ângx_log_tâ has no member named âfacilityâ src/core/ngx_log.c:699:9: error: statement with no effect [-Werror=unused-value] src/core/ngx_log.c:700:27: error: ângx_log_tâ has no member named âpriorityâ src/core/ngx_log.c:700:9: error: statement with no effect [-Werror=unused-value] src/core/ngx_log.c: In function âlog_exitâ: src/core/ngx_log.c:721:23: error: ângx_log_tâ has no member named âsyslog_setâ src/core/ngx_log.c: At top level: src/core/ngx_log.c:674:1: error: ângx_set_syslogâ defined but not used [-Werror=unused-function]

etc

Attempted to use 1.4 patch.

splitice avatar Jul 10 '13 11:07 splitice

Just so you know the hunks

Hunk #1 FAILED at 10. Hunk #2 succeeded at 23 (offset 2 lines). Hunk #3 succeeded at 54 (offset 2 lines). Hunk #4 succeeded at 67 (offset 2 lines). Hunk #5 FAILED at 144. Hunk #6 succeeded at 156 (offset -1 lines). Hunk #7 FAILED at 199. Hunk #8 succeeded at 496 with fuzz 2 (offset 70 lines). Hunk #9 succeeded at 545 with fuzz 2 (offset 13 lines). Hunk #10 succeeded at 570 with fuzz 2 (offset 24 lines). Hunk #11 succeeded at 664 with fuzz 2 (offset 60 lines). 3 out of 11 hunks FAILED -- saving rejects to file src/core/ngx_log.c.rej patching file src/core/ngx_log.h Hunk #2 FAILED at 68. Hunk #3 FAILED at 228. 2 out of 3 hunks FAILED -- saving rejects to file src/core/ngx_log.h.rej patching file src/http/modules/ngx_http_log_module.c

splitice avatar Jul 10 '13 12:07 splitice

[and, also, can you add new tag with patch for 1.5 then?]

msva avatar Jul 10 '13 18:07 msva

Thanks for your report. It seems nginx-1.5.2 change the error_log structure greatly. I'll try to fix this problem this weekend.

yaoweibin avatar Jul 11 '13 16:07 yaoweibin

Hi there! Any news? :)

msva avatar Jul 15 '13 18:07 msva

Yeah multiple error log directives are now supported, I can see how this might require more major changes. Take your time and get it right :)

splitice avatar Jul 17 '13 02:07 splitice

Any progress towards 1.5.0?

splitice avatar Aug 09 '13 08:08 splitice

Hi guys,

Any news about 1.5? :)

adnae avatar Nov 25 '13 10:11 adnae

https://github.com/splitice/nginx_syslog_patch

Includes 1.5.6 support (access log only). I have no interest in doing error_log support at this time.

I upgraded it over the weekend, this patch hasnt had QA internally yet. Feel free to let me know if it has any problems.

splitice avatar Nov 25 '13 11:11 splitice

What would be needed to implement error_log support?

simao avatar Jun 13 '14 09:06 simao

Switching to the latest official version of Nginx where this is already built-in might do it. ;-)

moll avatar Jun 13 '14 09:06 moll

I tried that. it doesn't work properly. I am currently submitting some bugs to the nginx project, like this https://bugs.launchpad.net/nginx/+bug/1329400

Also has another bug when syslogd is restart nginx doesn't properly reopen the socket so all the log msgs are lost.

simao avatar Jun 13 '14 09:06 simao