yao-msft

Results 75 comments of yao-msft

> Edit: I'd like to rebase this on master first to ensure the additional expected return codes can be used Sure, thanks

Though the tests were fixed, I just realized AdvancedInstaller is an installer authoring tool that supports exe, msi, msix, appv, etc. We may need to reevaluate how we approach this...

> > In that case, would changing this to advInstallerExe suffice, which would allow for advInstallerMsi as well? > > @yao-msft Thoughts on this approach? More granular definitely works. If...

For updating all the package dependencies, we may need some internal reviews to determine which versions to use. For example, we may prefer versions with long term support instead of...

Just my 2 cents before we get too far into implementation. I'm not sure if this is of high importance since we already validated the zip hash before extracting. If...

I can repro the issue. It is due to a refactor which moved all core logic of index creation into WingetSourceCreator, and IndexCreationTool was not updated to call WingetSourceCreator correctly....

This is actually because Calculator app is not in the curated list of the experimental store source or the winget source. winget is not able to correlate the installed app...

If you are looking for stable releases, this will be included in v1.5 client release tracked by milestone here https://github.com/microsoft/winget-cli/milestone/39 It is planned to be released around May If you...