MetaR-CNN icon indicating copy to clipboard operation
MetaR-CNN copied to clipboard

Report a bug in meta training phase 2

Open Ze-Yang opened this issue 4 years ago • 2 comments

There is a bug in the function filter_class_roidb(roidb, shot, imdb) in line 59 of file MetaRCNN/lib/roi_data_layer/roidb.py, resulting in actual novel shots exceeding designated shots. For instance, supposing we have collect enough bounding boxes of novel class 'sofa'. At this time, if an image contain 2 bounding boxes (one for whatever base class while the other is 'sofa'), we hope that this image will be excluded, otherwise extra 'sofa' will be used in training. However, since this image contains a base class bounding box, variable flag will be turned into True, making it be included in the training data. Thus, I think this is a bug need to be fixed. Thanks.

Ze-Yang avatar Nov 05 '19 09:11 Ze-Yang

We have updated roidb's key and value by update_keyvalue

yanxp avatar Nov 05 '19 14:11 yanxp

Actually, r[k] will never be a list. Thus, I consider nothing will be updated through https://github.com/yanxp/MetaR-CNN/blob/353b4ed25e4b2ba23442f999b3990d5b90b30345/lib/roi_data_layer/roidb.py#L54.

Ze-Yang avatar Nov 05 '19 15:11 Ze-Yang