videojs-panorama icon indicating copy to clipboard operation
videojs-panorama copied to clipboard

needsUpdate in player's paused state

Open kuehn-sba opened this issue 7 years ago • 5 comments

Videojs normal behaviour is an update in pause state. So can you please remove the paused condition in animate function (seen in L591 in videojs-panorama.v5)?:

if (!this.player().paused()) {

thx..

kuehn-sba avatar Apr 06 '17 09:04 kuehn-sba

This issue should be fixed.

yanwsh avatar Apr 12 '17 15:04 yanwsh

no it isn't. There is still "if (!this.player().paused())", which will not update frames in pause mode (for seeking, scrubbing a.s.o.)

kuehn-sba avatar Apr 24 '17 06:04 kuehn-sba

Why do you want to update when video paused?

Rendering 3d video is super expensive, it exhaust lots of CPU and memory, so my idea is to avoid rendering if video paused.

But i add additional code to check if user seek the videojs progressbar, so if user scroll the progress bar, it will also updated.

So let me know in which condition its not working.

Thanks.

yanwsh avatar Apr 25 '17 05:04 yanwsh

Wait, i double check, it's not working now. It's a bug. Thank you.

yanwsh avatar Apr 25 '17 05:04 yanwsh

This is supported on v1.0.0, please check here

yanwsh avatar Jul 09 '17 07:07 yanwsh