Yann Hamdaoui

Results 298 comments of Yann Hamdaoui

Although the code is a bit noisier (need to box and unbox quite a bit more), the preliminary results are encouraging. After a first trimming round from 464 to 74...

I'm not sure of the optimum, but reducing it further to 56 bytes wasn't beneficial,and is actually less performant than 72. It also costed a lot more in term of...

This was an interesting experience, but this effort is superseded by #2045.

> Do you know how to reconstruct a GenericUnifType from GenericUnifRecordRows. The best, if those record rows are coming from destructuring a unif type to begin with, is to keep...

> To de-duplicate the code between is_subsumed_by and unify, we can just call unify where we need in is_subsumed_by. I'm not sure to understand what you mean here. For example,...

> It's because the lsp snapshot tests have changed -- you've changed docs in the stdlib and so the hover text in the lsp is different. Running cargo test -p...

I'm taking over this PR for the foreseeable future, unless @Eckaos thinks he has the time to bring it down the finish line.

After some thorough investigation, I think I understand what's happening and I convinced myself that it makes sense (although in the test case it adds a bit of noise, it's...

@jneem I believe this can be closed given that https://github.com/tweag/nickel/pull/2031 has been merged?

I think it's reasonable. Those options are useful to minimize the markdown output when one is only interested in one particular field, but It's probably less useful for a JSON...