Yann Braga

Results 250 comments of Yann Braga

I'll start adding my findings as comments, hope you don't mind! I wonder why Chromatic didn't pick this up, I guess we don't have a story for such component.. but...

I wonder if the icons becoming smaller is also intended [previous] --------------------------------------------------- [this PR] ![image](https://user-images.githubusercontent.com/1671563/184324889-a5777a11-c872-4cd4-9fba-f10bd64f050f.png)

Hey everyone, thanks a lot for opening this issue and adding so much information here. I can confirm this issue is happening in `@storybook/vue` but not in `@storybook/vue3`(works correctly there)....

> Thanks for the workaround @yannbf. I had thought of something similar but didn't know enough about supported queries to make it work. Putting the two together, I think I...

Hey @ndelangen shall we merge next into this and check what's the next step?

By the way, I wanted to ask two things: - When I run `npm run-script build` it takes like 10 minutes to build. Do you have any idea why? -...

Sample of the change: ![selection_286](https://cloud.githubusercontent.com/assets/1671563/25566287/5a51e9fc-2dac-11e7-9ad7-22600eb7aef9.png)

English is not mine either, and yours is very good, don't worry. It actually would be nice to expose that flag to the dev, because there may be a case...

The effect is related to the following code: https://github.com/mswjs/msw/blob/86c23ec16c10698eb329798e883980a9b9159f05/src/setupWorker/start/utils/getWorkerInstance.ts#L25-L33 commenting it out removes the loop and flaky behavior, but of course msw doesn't work as expected

> The question is why `navigator.serviceWorker.controller` becomes undefined? > > It's highly recommended to have the MSW set up on the application's side. That way your app registers the worker,...