SwiftPasscodeLock icon indicating copy to clipboard operation
SwiftPasscodeLock copied to clipboard

Swift 3 Update :D

Open johisco opened this issue 8 years ago • 11 comments

johisco avatar Sep 16 '16 10:09 johisco

Please

antjebara avatar Oct 06 '16 13:10 antjebara

Hey guys, I temporarly use the @zahlz fork repository which is Swift 3 compatible.

https://github.com/zahlz/SwiftPasscodeLock

I hope they will create a PR.

bill350 avatar Oct 10 '16 14:10 bill350

Just download this repository and use the build in converter in Xcode. This project does not cause any issues whatsoever. Just don't include it using one of the package managers, as you never should anyway.

jabwd avatar Jan 12 '17 09:01 jabwd

@jabwd is there a reason we should not be using package managers? (i assume your talking about cocoapods, carthage, SPM)

waltermvp avatar Feb 09 '17 10:02 waltermvp

@waltermvp In my opinion, they cause more trouble than they're worth. Case and point: People want this repo updated but can just do it themselves without any trouble. You need to fork anyway if you even were planning on slight updates. git submodules > SPM on linux > manual inclusion.

Its a dependency for managing dependencies..

jabwd avatar Feb 09 '17 10:02 jabwd

You have a look at this repo for a while, which supports Swift3 https://github.com/velikanov/SwiftPasscodeLock

p.s.: I hope that these two repos will be merged at some point

ziogaschr avatar Apr 05 '17 09:04 ziogaschr

@ziogaschr thanks. I'm considering to switch to your fork. I see yours has new patches and still under actively developed.

mssun avatar Apr 07 '17 21:04 mssun

Thanks @mssun. It's @velikanov's repo, but yes we are trying to keep it up to date. It will be nice if we can keep only one repo (the main one - this) so as we all contribute at one place.

ziogaschr avatar Apr 09 '17 10:04 ziogaschr

So @ziogaschr, the https://github.com/velikanov/SwiftPasscodeLock is the "official" ?

bill350 avatar Apr 12 '17 13:04 bill350

Yep

waltermvp avatar Apr 12 '17 13:04 waltermvp

xexe, no this one from @yankodimitrov is the official. Although in my view the @velikanov's one is more updated.

@yankodimitrov made us contributors (thanks for that honor), although we never merged the two repos so as we can continue with this one. I am using this lib in a production App and the missing bit in this repo doesn't allow me to continue contributing here.

So usually, I make a lot of changes at my repo https://github.com/ziogaschr/SwiftPasscodeLock, test them live for a while and the push them to @velikanov's repo.`

ziogaschr avatar Apr 13 '17 07:04 ziogaschr