Yanick Champoux

Results 123 comments of Yanick Champoux

I agree with the agreement. Closing. :-)

> So I'm wondering will this solution suffice for the long run or will it break down the road? It might have to be tweaked if svelte takes the configuration...

I'll go ahead and close this issue, as we have tests in the repo that use `toMatchSnapshot()` (https://github.com/testing-library/svelte-testing-library/blob/main/src/__tests__/render.test.js#L73)

It seems that using `happy-dom` instead of `jsdom` fixes the problem!

> @yanick I think this ticket should be considered outside the scope of svelte-testing-library closed. I don't think switching our tests to happy-dom is the right move at this time...

#238 should take care of this

I tried it on my machine, and there are trailing spaces for v1.68 as well. I went down to v1.58, and witnessed the spaces there too.

Okay, commit 6aa9541e0a8ca42a72e761e9603803efd2d9f396 seems to be causing problems. Before the commit, we get '1 ' instead of '1', but after, we get ' '. Which I'd say is worse. :-)

Just want to say that you, my friend, are an OCI/XS wizard. Hat off to you.