WallPaperChanger icon indicating copy to clipboard operation
WallPaperChanger copied to clipboard

Watermark?

Open m-haisham opened this issue 2 years ago • 12 comments

The watermark is not adding anything and is distracting (imo), I'd suggesting moving the date (in the middle) to the bottom right of the application. It could be shrunk and moved to a corner (maybe top right) where it would be much less inconspicuous.

This is just a suggestion.

m-haisham avatar Sep 08 '21 19:09 m-haisham

Ok, I will consider this suggestion, as for the date text, if it were moved to the top right, the widget must also be moved.

yangman946 avatar Sep 08 '21 21:09 yangman946

I was thinking of placing the date where the current watermark is placed or just above the widget.

m-haisham avatar Sep 09 '21 05:09 m-haisham

Is this including the day as well?

yangman946 avatar Sep 09 '21 06:09 yangman946

Yeah, The whole widget that shows the day and the date.

Also when we move the watermark, we should probably also add the compiled time to it.

m-haisham avatar Sep 09 '21 08:09 m-haisham

What is the compiled time?

yangman946 avatar Sep 09 '21 08:09 yangman946

What is the compiled time?

The moment where we save the image using the updated weather data

m-haisham avatar Sep 09 '21 09:09 m-haisham

The moment where we save the image using the updated weather data

So are we proposing to display the time onto the user's desktop wallpaper?

I was thinking of placing the date where the current watermark is placed or just above the widget.

To fix this issue, I propose we add an array of tuples representing coordinates, and enable the user to pick which visual configuration they like (we can add a bunch of demo's on the readme file) and through code, users can toggle between layouts such as the current one or the one you have proposed. (i quite like the current layout)

I am also completely open to removing or replacing the watermark (it was just something I added really early on: now that there are multiple contributors, I am fine with removing it)

yangman946 avatar Sep 09 '21 10:09 yangman946

So are we proposing to display the time onto the user's desktop wallpaper?

Not the time exactly. Just the time when the weather information was retrieved so the users can know if its outdated.

I propose we add an array of tuples representing coordinates

This would be ideal, we can create a dict with names as keys and the type of layout can be selected using environmental variables

m-haisham avatar Sep 09 '21 12:09 m-haisham

Ok, that sounds good, I'll begin implementing this ASAP.

yangman946 avatar Sep 09 '21 13:09 yangman946

Ok, I have committed the changes discussed, allowing users to customize the layout of the screen. So far I've:

  • added a dictionary of configurations (users can modify or append to this)
  • added the ability for users to change fonts
  • added compile time
  • added the ability for users to change the location of the screen elements (date text, compile time text, widget)
  • made the water mark smaller and gave the option to hide the water mark (and also hide the compile time text)
  • updated readme accordingly.

I still have to save the layout using environment variables. I'll keep this issue open until once I am sure that no errors are present and no further changes are required.

Edit: grammar.

yangman946 avatar Sep 10 '21 13:09 yangman946

Say, does pillow support drawing emoji's onto images. Because that would be an excellent way to spice up the text.

For example:

  • Instead of Updated: we can use ⏱.
  • Weather emojis: ☁⛅⛈🌤🌥🌦🌧🌨🌩🌪
  • Since we are usually updating hourly, we can even add these, 🕐🕑🕒🕓🕔🕕🕖🕗🕘🕙🕚🕛

m-haisham avatar Sep 10 '21 13:09 m-haisham

Say, does pillow support drawing emoji's onto images.

I think pillow supports emojis, I'll confirm this ASAP.

For weather emojis, the weather API actually provides weather icons, I have experimented with this in the past, but haven't found them particularly useful. I don't think weather icons/emojis are necessary as the widget already shows a weather icon.

Since we are usually updating hourly, we can even add these, 🕐🕑🕒🕓🕔🕕🕖🕗🕘🕙🕚🕛

Sounds good, I'll consider adding these emojis.

yangman946 avatar Sep 11 '21 00:09 yangman946

I have now added clock emojis in 7255669081b5bf002f46d69c2f0b1f84905a7dec and I have also repurposed the updating timer as a working clock, however, I will have to write a new batch file that can be run every minute to refresh the clock value. I am closing this issue due to inactivity.

yangman946 avatar Sep 12 '22 05:09 yangman946