Danny Yang

Results 182 comments of Danny Yang

Depends on whether we want to keep completions list short, i suppose.

Thanks for looking into this! cc @jvansch1 regarding potentially bundling pandas-stubs w/ Pyrefly Maybe we could do what we do for django, which is to prompt the user to install...

Thanks! This change looks good, though I don't think this completely handles #43, per sam's comment here: https://github.com/facebook/pyrefly/issues/43#issuecomment-3226102136

Hmm, one issue I found is that the type variable is not being solved by the call arguments. In the test case you added, I see that `x: C[int] =...

I think the solution for #43 probably requires making a new Forallable type for ParamSpecValue and possibly also Concatenate That would allow passing the type params when we solve a...

https://github.com/facebook/pyrefly/issues/1469 is a similar issue for ParamSpecs I think the representation of TypeVarTuple somehow needs to encode a requiredness, otherwise we'll have to make a union of each possible length...

Pyright seems to consider the argument requiredness if the function and arguments are passed in together, which successfully handles the original example https://pyright-play.net/?strict=true&code=GYJw9gtgBALgngBwJYDsDmUkQWEMoBUAUEQCYCmws5AzjANoEAqNANFEwLoAUwAXFADCAQwA2o4QCNR5eoxad2XdgWEg0NAcxoBKKAFoAfLACuCGfJqc%2BRKHaghhSGuSgBRAB4BjcghhIwFG49MkooLzFRSWEvAGtuDwFUGHY4JJR8AF4oAEYdAQRhGhoSEHIAN3IxAH14BHJuGFoYbgjxaLj2PL0AYihyEHAQAH4iMsqauoamulbIjtiurp1eqDBYoA but if just the function is passed...

hey, that's pretty good! only a few dozen errors

> I know how to implement a solution where "platform bools" are treated specially, but it requires distinguishing between platform bools and other statically-known bools, which makes a mess of...