yanet icon indicating copy to clipboard operation
yanet copied to clipboard

Control plane workers config parsing

Open TheRandomCharacter opened this issue 1 year ago • 3 comments

Adds parsing of control plane workers configuration from config file. Expected config file section is:

"controlPlaneWorkers": [
    {
        "core" : 42,
        "interfaces": [ <interface_name_string> ]
    }
]

In case section is not present, configuration for single control plane worker, responsible for all dataplane interfaces and residing on controlPlaneCoreId is generated. This Is done to ease transition on already deployed appliances.

Section is checked for

  • Every configured dataplane interface is assigned to a control plane worker
  • Each interface is assigned to single control plane worker
  • Interfaces not configured for use by dataplane are treated as errors

TheRandomCharacter avatar Apr 22 '24 18:04 TheRandomCharacter

Could you also add the description to the commit message?

ol-imorozko avatar Apr 23 '24 11:04 ol-imorozko

Fixed the logic and reworked it to configuration in terms of interface names, not dpdk port ids.

TheRandomCharacter avatar Apr 25 '24 15:04 TheRandomCharacter

Good enough but I would prefer to wait with this until the whole work is done. Also we have to document the configuration changes

GeorgyKirichenko avatar Apr 26 '24 12:04 GeorgyKirichenko

Superseded by another PR

GeorgyKirichenko avatar Sep 20 '24 13:09 GeorgyKirichenko