tabular-dl-tabr icon indicating copy to clipboard operation
tabular-dl-tabr copied to clipboard

Published 20 hours ago • verified publisher icon yandex-research

Bug in make_parameter_groups

Open NikolayXHD opened this issue 11 months ago • 1 comments

Hi! The following line in method make_parameter_goups looks very much like a mistype

https://github.com/yandex-research/tabular-dl-tabr/blob/75105013189c76bc4f247633c2fb856bc948e579/lib/deep.py#L364C46-L364C60

params_with_wd if needs_wd else params_with_wd

because of it we never add anything to params_without_wd which defeats the purpose of zero_weight_decay_condition

NikolayXHD avatar Feb 25 '24 04:02 NikolayXHD