terraform-provider-yandex icon indicating copy to clipboard operation
terraform-provider-yandex copied to clipboard

Published 20 hours ago • verified publisher icon yandex-cloud

PR #207 was reverted. What reason?

Open psmolkin opened this issue 3 years ago • 2 comments

I noticed the PR#207 was reverted by this commit (https://github.com/yandex-cloud/terraform-provider-yandex/commit/0b1d61efd7c4e6fa7d232ff23f9c5f61a44bb644) from @apilikov without any messages.

I would like to know a reason and can I expect to see my changes in the repository again 🙄

psmolkin avatar Feb 17 '22 16:02 psmolkin

Hello! It is a legitimate question that you are asking :-), so the reason is that I accepted your code without tests. Thought I could write them myself but didn't find time and had to rollback your changes as we cannot accept new objects without tests. So, there are two possible options: you can submit new patch with acceptance test (not sure if you are familiar with it) or you can try waiting until I have done it myself. 😊

apilikov avatar Feb 18 '22 10:02 apilikov

I've just recreated the patch https://github.com/yandex-cloud/terraform-provider-yandex/pull/242

psmolkin avatar Feb 25 '22 15:02 psmolkin