libyaml
libyaml copied to clipboard
yaml
Add Solaris compilation fix from Perl binding repo.
Originally from Andy Grundman [email protected] circa August 2014.
Not sure if we can get a solaris test env. I can ask around.
@sigmavirus24, what's the current state of CICD for libyaml?
@ingydotnet the current state is only on Travis, although I'm looking at how we can get stuff running on Windows with AppVeyor. Unfortunately, windows is not my strong suit so I think I'm going to simply make an issue for someone to tackle if they know what they're doing.
@sigmavirus24 think we can go ahead and apply this?
Since we don't have CI testing for solaris, releasing it would likely get someone to complain if it breaks anything. Then we ask the person reporting the bug to do our CI!!! :)
@sigmavirus24, I was kinda kidding. Mostly this is a simple patch and we've been sitting on it for a year. No idea how much solaris usage we have.
@hanetzer @sigmavirus24 @perlpunk I had to a merge conflict with some other new ifdef stuff, and I wanted to make sure it looks right.
It looked right to me and all the CI tests pass, but please review. Cheers...
@andygrundman Hi. Your Solaris patch for YAML::XS just made it into libyaml.
Was wondering if you or ActiveState had any resources for CICD testing on Solaris or HPUX?