react-native-orientation icon indicating copy to clipboard operation
react-native-orientation copied to clipboard

Moved package.json's rnpm config to react-native.config.js

Open chrisspankroy opened this issue 5 years ago • 7 comments

This is going to be required in the release after RN 0.60. I think I did this the right way, although someone else should probably take a look. This closes #352

chrisspankroy avatar Jul 08 '19 20:07 chrisspankroy

One thing I'm not sure about is if it should be

module.exports = {
    project: {
        ios: {
	    project: 'iOS/RCTOrientation.xcodeproj',
	},
	android: {
	    "packageInstance": "new OrientationPackage()"
	}
    }
};

or

module.exports = {
    dependency: {
        platforms: {
            ios: {
	        project: 'iOS/RCTOrientation.xcodeproj',
	    },
	    android: {
	        "packageInstance": "new OrientationPackage()"
	    }
        }
    }
};

Is there a way to test which one works?

chrisspankroy avatar Jul 08 '19 20:07 chrisspankroy

+1

mayconmesquita avatar Aug 08 '19 01:08 mayconmesquita

Is this planned to be merged in at some point? Is this project still maintained?

dawidvdh avatar Aug 14 '19 11:08 dawidvdh

Last PR closed was November of last year. This project is not maintained.

zbagley avatar Aug 19 '19 21:08 zbagley

@yamill last activity on GitHub was on 17 September 2018 and his personal website is down... I don't think this wonderful package will be ever maintained again from him. :-( This is a fork updated version: https://github.com/wonday/react-native-orientation-locker

Fenopiu avatar Sep 02 '19 08:09 Fenopiu

I'm using this one and it worked perfectly on version 0.60.5

https://github.com/react-native-hooks/device-orientation

joaodematejr avatar Sep 17 '19 13:09 joaodematejr

@joaodematejr that hook only allows you to query the current orientation of the display.

This library allows you to lock down the orientation of the display, so the hook isn't a valid replacemet.

chrisparton1991 avatar Dec 11 '19 02:12 chrisparton1991