react-native-orientation icon indicating copy to clipboard operation
react-native-orientation copied to clipboard

Set Android unlockAllOrientations to use SCREEN_ORIENTATION_USER

Open mattvot opened this issue 7 years ago • 6 comments

#274 points out that the unlocking of orientation does not respect the users preferences.

Now when the Android device is physically rotated, but the orientation is locked in the OS, the orientation of the app respects the preferences.

mattvot avatar Apr 30 '18 12:04 mattvot

+1

NemanjaManot avatar Jul 13 '18 13:07 NemanjaManot

Anyone can review it? I already tested it and it worked for me.

lemagnetic avatar Jul 13 '18 18:07 lemagnetic

+1 It's working for me! Plus: What is different "SCREEN_ORIENTATION_USER" and "SCREEN_ORIENTATION_FULL_USER" in #298

nighttiger1990 avatar Oct 13 '18 13:10 nighttiger1990

@nighttiger1990 SCREEN_ORIENTATION_FULL_USER allows any of the 4 possible rotations, regardless of what the device will normally do (for example some devices won't normally use 180 degree rotation).

aleksey89 avatar Oct 15 '18 18:10 aleksey89

Will this be merged please? This should be the intended behavior

martykan avatar Jun 09 '19 12:06 martykan

Tested and approved, could one of the contributors please merge this?

Producdevity avatar Sep 16 '22 01:09 Producdevity

Sorry, this stack is something I'm no longer geared up to develop with and no longer use. Please take on the change in a new PR to merge.

mattvot avatar Mar 23 '23 09:03 mattvot