Maurice Wangleng Tan
Maurice Wangleng Tan
> So, Model#getDisplayPersonList() and Logic#getDisplayPersonList()? I think that is good.
> (Taken from https://docs.travis-ci.com/user/migrate/open-source-on-travis-ci-com/#existing-open-source-repositories-on-travis-ciorg) > > If I'm reading this correctly, this means that documentation updating can wait for a while longer? This is for _existing_ open source projects. If...
I feel that for this one a warning should suffice? Unless we are ok with putting `suppressWarning` or `//CHECKSTYLE:OFF` all around these method, which may make it a bit disorganized.
> Some implementations write the comment as this handles null as well, but I think we overwhelmingly have instanceof handles nulls. > > Some implementations don't even put any comment,...
> ExitCommand (I think we definitely can't write for this :P) The test will type in the `exit` keyword, and then test that the `MainWindow`/`MainApp` is closed.
> Let's update this method to not update the filtered list. I am going to make a wild guess that the intention of the original developer was that, if the...
The "corner case" meant the scenario when your list is actually filtered (and not showing all person), so the ideal action shouldn't even be to reset the list to show...
I am unable to reproduce this problem. May I know which team is having this problem?
Ah OK, thanks for your inputs @eugenepeh and @lproperty! May I also know whether both of you ran the GUI tests in `headless` mode to pass the tests?
Thanks for confirming. Actually, I have experienced a different issue before during my CS2103T time, whereby I cannot pass a HelpWindow GuiTest because TestFx wasn't able to press 'F1' on...