flutter_badges icon indicating copy to clipboard operation
flutter_badges copied to clipboard

Add animationController and appearanceController to give better control over badge's animation

Open wamynobe opened this issue 1 year ago • 4 comments

Connection with issue(s)

#127 Resolve issue #??? #127

Connected to #??? #127

Testing and Review Notes

I am not sure but I ran all current test cases and they all passed. Because this pr will not cause any breaking changes so I think It will be fine 😃

Screenshots or Videos

To Do

  • [x] double check the original issue to confirm it is fully satisfied
  • [ ] add testing notes and screenshots in PR description to help guide reviewers
  • [ ] request the "UX" team perform a design review (if/when applicable)

wamynobe avatar Dec 22 '23 08:12 wamynobe

There is a problem that the AnimationController will call dispose() more than once.

wamynobe avatar Dec 22 '23 09:12 wamynobe

@yadaniyil Can you take a look on this please?

wamynobe avatar Jan 21 '24 05:01 wamynobe

@M-ixai-L Can you take a look on this pls?

wamynobe avatar Feb 28 '24 03:02 wamynobe

@M-ixai-L There are some cases that I want the badge to animate even if it did not change the value. In these cases I think animationController.forward will be fine. So getting the animation controller instance from badge class is a simple way to archive that.

wamynobe avatar Aug 12 '24 07:08 wamynobe