flutter_badges
flutter_badges copied to clipboard
Add animationController and appearanceController to give better control over badge's animation
Connection with issue(s)
#127 Resolve issue #??? #127
Connected to #??? #127
Testing and Review Notes
I am not sure but I ran all current test cases and they all passed. Because this pr will not cause any breaking changes so I think It will be fine 😃
Screenshots or Videos
To Do
- [x] double check the original issue to confirm it is fully satisfied
- [ ] add testing notes and screenshots in PR description to help guide reviewers
- [ ] request the "UX" team perform a design review (if/when applicable)
There is a problem that the AnimationController will call dispose() more than once.
@yadaniyil Can you take a look on this please?
@M-ixai-L Can you take a look on this pls?
@M-ixai-L There are some cases that I want the badge to animate even if it did not change the value. In these cases I think animationController.forward will be fine. So getting the animation controller instance from badge class is a simple way to archive that.