Iacopo Spalletti
Iacopo Spalletti
@balrok If I understand correctly your patch will avoid bump2version to update the config file, and one has to rely on the explicit configuration which will only update the version...
Apparently this is caused by python `ConfigParser` always appending a whitespace after the `=` even on multiline values. AFAIK there is no way to prevent this in the `ConfigParser` One...
@balrok If I understood correctly your approach, it looks absolutely sane
Doesn't look like it's working this way ATM. More detailed tests tomorrow. Assigning to me for review
Showing the main view it's quite straightfoward: code in https://github.com/divio/django-cms/blob/develop/cms/views.py#L96-L120 will take care of this, provided that we change https://github.com/divio/django-cms/blob/develop/cms/views.py#L108 from: ``` not page.is_published(current_language) and request.toolbar.edit_mode: ``` to ``` if...
The idea of apphooks is to plug directly in django urlconf to be a zero-overhead solution to dynamic application hookin Thus you can't load an apphook, if you don't know...
@Aiky30 yes, unfortunately it's still an issue
It might be a sensible approach. Alternatively we can create a specific form to handle extensions. Page/Title extensions may have a lot of fields and this can make Advanced settings...
I think it can be useful, but probably we would need a test for it. I also see test failures, IDK if by changes this PR or pre-existing (and now...
@ianare please let me know if you need any support to handle the requested changes