Yair Morgenstern

Results 370 comments of Yair Morgenstern
trafficstars

I don't see a reason for there to be 2 functions. If you have a function that's 'between X and Y', then that can also serve you for just 'below...

Ah I see, the functions internally read the parameters from the unqiues, so only the second half of them can really be 'generalized' So I think the generalizable part is...

Almost perfect!! Now just notice that all the compare functions are actually the same - min

I'll merge this now due to other prs conflicting

There's an assumption here that each nat wonder only gives one stat, that will break really fast when modders start adding multiple uniques. Instead we should assume we can gain...

Much better! Still removes the current implementation, please return it so modders can gradually migrate

Tried to repro, Discord says this is caused by mods that have *just been downloaded* so if we can repro we can fix