Move multiplayer turn notification translations to our translation system

[Azzurite]

Currently, the Android multiplayer turn notifier background worker uses Android-specific translation files in android/res/values-*. This is because the turn notifier is basically a separate application - not sharing any state with the main Unciv application. And since the Translations do have state, it "couldn't" be used so far by the turn notifier, as it would result in NPEs.

The correct solution though is what I did with the Gdx.files recently - which is affected by the same problem. To create the Translations class within the turn notifier, same as it is being created in UncivGame. and then use that freshly created instance.

[Azzurite]

A minor question is how expensive it is to create the Translations class freshly. If it takes several seconds or something like that, then it might make sense to create a generator (like for fastlane translations) instead and keep using the Android-specific translation files.

[SomeTroglodyte]

several seconds

From a desktop log ~ 67ms on my (maybe faster than average) desktop box, for the configured language, provided all dependencies are already loaded (like the settings), and GC doesn't need to clean up while doing it. Corresponds to 15fps :upside_down_face: .

[ofetios]

I've noticed that regardless of what language I have selected (in-game) I still get the translated notifications. I think values-__ are chosen depending on system language

[Azzurite]

I mean, yeah, that's how Android-specific translations work. Always uses your system language by default, need to add special handling if you want something else.

[github-actions[bot]]

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 15 days.

[SeventhM]

Will need someone to actually look into this before I personally think it's closable. @yairm210 might disagree, though. Actually, while this doesn't fix the problem of "it follows android's set language", is there a way to at least have a github action to update these strings based on translations, or is that more hassle than it's worth?