Unciv icon indicating copy to clipboard operation
Unciv copied to clipboard

Missing mods in Downloadable mods list

Open stixZman opened this issue 2 years ago • 18 comments

Hello,

Since a few days ago (I´m not sure if it´s related to latest 4.0.14 release or not) I´m missing some of the most starred and downloaded mods for Unciv in Android app (don´t know if it occurs in the desktop app)

If I navigate to unciv mod topic URL https://github.com/topics/unciv-mod I´m missing some repositories like 5Hex tileset, RekMod and many more.

Can anyone help me to download these mods from repositories? I uninstalled Google Play Store version in order to install apk directly from latest github release (since it takes a few days to update the release on Play Store)

Thank you very much in advance.

stixZman avatar May 11 '22 11:05 stixZman

If you know the repo URL, there's a manual button (accepts repo url's if that repo uses 'master' as primary branch name, or a complete branch url). image

But thanks for the heads-up. Can't believe querying directly on github also fails, but forewarned is good. ...Yes, seems a github failure. Nothing we can do. Maybe you could do us the favour to escalate directly to github?

SomeTroglodyte avatar May 11 '22 12:05 SomeTroglodyte

Yeah, that's weird, 5Hex and Rekmod are not listed... although they have the unciv-mod tag. Sorting by number of stars, 5Hex should be on top of the list...

EDIT:

don't do that!! :D

You can manually add these mods on Android by connecting your device to your PC (a bit cumbersome, but that's the only workaround until Github fixes the problem...). It's on you if you want to wait or you really need the mods.

  1. On your PC, go to https://github.com/ravignir/5Hex-Tileset, click on "Code" (green button), and select "download zip"
  2. Connect your android device to your PC through USB, and select "Explore" (your android device may ask for a permission first, click "Allow" if needed)
  3. Navigate to Android/data/com.unciv.app/files/. Here, creates a mods folder, and inside it, a 5Hex folder. So it gives Android/data/com.unciv.app/files/mods/5Hex.
  4. Open the zip file, and copy the jsons folder, game.atlas, game.png, game2.png, game3.png, game4.png in Android/data/com.unciv.app/files/mods/5Hex created in point 3 (images folder is not needed).
  5. Unplug your Android device from you PC (eject/remove USB device if available) and start Unciv. 5Hex should appear in your installed mods list. Enable it as usual.

However, to uninstall it (when you'll want to), it won't work from Unciv mods manager (because the mod manager does not install/remove mods from the folder we created). You will have to connect again your Android device to your PC, erase manually the mods folder in Android/data/com.unciv.app/files, then start Unciv and click on "Remove 5Hex" to clean the installed mods list.

Did I say it was cumbersome? :D

Ouaz avatar May 11 '22 21:05 Ouaz

Oh my. Going through MTP and two devices? Just copy the link on Android into the box I showed, done. Android has text copy and paste.

P.S.: it's escalated

SomeTroglodyte avatar May 11 '22 21:05 SomeTroglodyte

Oh god, I thought you said that even using "Download mod from URL" doesn't work... I misread. -_-'

I edit my previous post.

Ouaz avatar May 11 '22 21:05 Ouaz

Thank you both for your help about manually installing these mods! I finally got mods easily installed using "Download from URL" method.

As it´s not an unciv issue and it´s related to github, you can close this ticket.

Thank you again!

stixZman avatar May 12 '22 06:05 stixZman

I've also posted a ticket directly to github, hopefully we'll get a response from either the forum or them directly soon

xlenstra avatar May 12 '22 14:05 xlenstra

Still no response about this from github and topic search is still missing many mods.

stixZman avatar May 13 '22 07:05 stixZman

Seeing as we still have no response from github, maybe we should start thinking about alternatives, as github seemingly is unreliable?

xlenstra avatar May 14 '22 16:05 xlenstra

It could well be that we hit some upper limit of their search engine, maybe even documented but devilishly well-hidden-so. Too lazy to check.

Also - moving - mulling the idea for the last few days, nothing comes to mind, and with the seeming shift to even less privacy- and open- friendliness than before in the space provider market (see the aggressive closure of we.tl,...) - dunno. A repo maintaining only a json pointing to mods, maybe with extra value added by that repo's maintainers? Every mod author >= N stars automatically made editor? A parseable wiki???

SomeTroglodyte avatar May 14 '22 21:05 SomeTroglodyte

I've also posted a ticket directly to github, hopefully we'll get a response from either the forum or them directly soon

Update: I've heard back from github support, and they fixed the problem specifically for 5hex-tileset. I've contacted them again as this doesn't solve our underlying problem (notably RekMOD and deciv-redux are still missing), and will tell more when I hear back.

xlenstra avatar May 16 '22 19:05 xlenstra

Update: Github responded with the following:

Thanks for the explanation there.

I've checked this and I get different results everywhere.

I used the GitHub CLI gh search repos --topic unciv-mod --limit 200 and got 154 results. This uses the REST API.

Using the GraphQL Explorer, I got 194 results.

Query (you have to paginate this - 100 is the maximum it will return):

query MyQuery {
  topic(name: "unciv-mod") {
    repositories(first: 100) {
      edges {
        node {
          nameWithOwner
        }
      }
      pageInfo {
        hasNextPage
        endCursor
      }
      totalCount
    }
  }
}

On GitHub.com, it's saying 164 right now.

I have opened an issue with our search team, and I will let you know when I have an update. To set expectations, search is complex, and so this may not be something that gets resolved very quickly. It is likely worth playing around with the different options above to see if one of them might be more reliable for your uses for now.

You could also cache some results to prevent repositories that were already listed from disappearing if we have a search outage, or if the repository drops out of the index for any other reason.

Sounds like the best plan to ensure that everything works is to move away from GitHub search after all. I'm personally fond of the "have a GitHub repo with a json with links to each mod in it", though other options are always possible.

xlenstra avatar May 18 '22 19:05 xlenstra

personally fond of

Thanks. Adds value by having the "curated" repo pattern. Like ubuntu distros not having the discord client because their repo maintainers are in accord with my evil prejudices :smiling_imp: :zany_face: ... or our hard block list (is this gone yet?)... Still, a lot of effort.

SomeTroglodyte avatar May 18 '22 19:05 SomeTroglodyte

@xlenstra - you didn't link said ticket. One might add that it even impedes the ability to manage PR's. Which seems to me could interest their staff far more than just a bunch of players not finding their mods.

I could push code to my Fork and open a PR in yours for it, but I can't at the moment do the same with alexban011/Unciv because the "choose a base repository" box fails the same way.

SomeTroglodyte avatar May 25 '22 15:05 SomeTroglodyte

xlenstra - you didn't link said ticket.

I'm pretty sure I'm unable to; I can't open the ticket in a private navigation window, so it seems to be a private ticket. I have posted all their responses here, so you shouldn't miss any information. If you want I can post what I send as well, though most of it is just explaining the problem.

One might add that it even impedes the ability to manage PR's. Which seems to me could interest their staff far more than just a bunch of players not finding their mods.

I could push code to my Fork and open a PR in yours for it, but I can't at the moment do the same with alexban011/Unciv because the "choose a base repository" box fails the same way.

I'm not completely certain whether this is the same issue though it could very well be related. It also appears to be worse than that: you can't even open a PR for alexban011's fork from yairm's main 'fork'.

xlenstra avatar May 25 '22 15:05 xlenstra

IS this still ongoing?

yairm210 avatar Jun 20 '22 20:06 yairm210

A quick check shows that REKmod cant be downloaded in-game, so I assume so.

xlenstra avatar Jun 20 '22 21:06 xlenstra

See "Achievements" - they're obviously no longer going for professionalism or quality, neither in their platform nor clientele (actually feels no longer appropriate to talk about contributors - da* ch* wa* seem more welcome). I vote abandon ship.

SomeTroglodyte avatar Jun 20 '22 22:06 SomeTroglodyte

Is this still ongoing?

Yes

Azzurite avatar Jun 20 '22 22:06 Azzurite

It's been a while, re-checked this and everything seems in order, all mods are properly retrieved

yairm210 avatar Jan 02 '23 08:01 yairm210