Unciv
Unciv copied to clipboard
yairm210
`TileSetConfig` not set on first load.
With ./gradlew desktop:run.
Freshly downloaded 5Hex is looking way darker in-game than the images suggest it should?
Feels like all the RGBs are squared.
The game.png seems fine:
After a restart it's fine:
Not sure how to reproduce… But I think it's happened before too, but with a JAR.
And Pix5, on Android:
How it's supposed to look:
Yeah. This is supposed to have the same colours as FantasyHex:
If I'm not mistaken, this has been brought up before and the conclusion was that this was the result of the tileset trying to override the default fantasyHex tileset
5Hex doesn't do that AFAICT thoiugh, and this is specifically after Pix5 was updated (https://github.com/AdityaMH/Pix5-Tileset/pull/2) to no longer do it, nor does the tile variants example.
5Hex doesn't do that AFAICT thoiugh, and this is specifically after Pix5 was updated (AdityaMH/Pix5-Tileset#2) to no longer do it, nor does the tile variants example.
I'm just download strike from github website, place it on folder, start game, greeny occur, delete from mod manager, restart, fixed automatically.
Cons: Can't update from mod manager
If I'm not mistaken, this has been brought up before and the conclusion was that this was the result of the tileset trying to override the default fantasyHex tileset
Yeah, but @will-ca suggest me to not override.
Oh! You know what? It's probably not due to overriding FantasyHex; It's probably due to TileSetConfig().useColorAsBaseTerrain being left at true (which would also happen if a tileset tries to override not FantasyHex, but Default).
Oh! You know what? It's probably not due to overriding FantasyHex; It's probably due to
TileSetConfig().useColorAsBaseTerrainbeing left attrue(which would also happen if a tileset tries to override not FantasyHex, but Default).
But i'm set it false
@AdityaMH Not about Pix5. I mean the config probably isn't being properly loaded on first mod download.
@will-ca Was this solved by your change?
I don't think I touched anything that would affect this… Test on latest master shows it still happens:
I think calling TileSetConfig.updateConfig(), TileSetCache.assembleTileSetConfigs(), or anything else in that stack when enabling/downloading a mod would do it. But I don't know the existing call hierarchy, and the best place to do that.
It's not just the colours, but the entire TileSetConfig that isn't being updated on first use of the mod. E.G. tileScale:
And somewhat relatedly (but a different issue), when you delete the active tileset, it doesn't automatically switch over to another one:
