Unciv icon indicating copy to clipboard operation
Unciv copied to clipboard

Custom Map UI not accepting inputs

Open TrueWolves opened this issue 2 years ago • 2 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Game Version

4.10.14

Describe the bug

While attempting to make a custom-sized map in the map creator, trying to input map sizes with the keyboard leads to multiple UI issues. Hitting the enter key or the ok button is often needed multiple times, entering the size each time and trying to generate the map doesn't consistently use the new map sizes requested. It's also not always clear why a map size on a rectangle map is being rejected and what sizes are accepted. (Mins, Maxes, and allowed ratios are not stated anywhere.)

This is effectively limiting me to generating only predefined map sizes.

Steps to Reproduce

Using a Galaxy S23 Ultra

  1. Go to Map Creator
  2. Select "Custom" on map size
  3. Attempt to enter a custom map size, or custom map height/width
  • From here it can require multiple inputs to enter anything
  1. Attempt to generate the map
  • From here what was entered isn't always saved, or sometimes entirely new values (usually too small) are used instead.

Screenshots

No response

Link to save file

No response

Operating System

Android

Additional Information

No response

TrueWolves avatar Mar 02 '24 21:03 TrueWolves

  • Input in NewGameScreen is fine, tested on Android 12 hardware
  • Map size correction should show a Toast with the reason - yes it does
  • The source for those is here: https://github.com/yairm210/Unciv/blob/master/core/src/com/unciv/logic/map/MapParameters.kt#L85
  • Size input fields are just fine in Map Editor too
  • The same Toast as above is not readable when Map Editor fixes sizes - one actionable issue found. Grey transparent background for the Toast is there, the text not.

Whatever the issue with text input you have is - the description is not very clear - it's not reproducible. You do not state the exact Android version, and you may have installed unusual keyboard apps (that said our input works fine with good ol' Hacker's keyboard or even with KeePassDX's pseudo-keyboard). Maybe you can clarify? Or revert to standard Android keyboard settings and retry? Or any other ideas to help understand what is happening?

SomeTroglodyte avatar Mar 04 '24 10:03 SomeTroglodyte

I think I found something (actually several somethings)... @TrueWolves - are you getting number input as separate "dialog" popups for number entry?

I can't even repro now, but a while ago I had them in an "S" AVD. They indeed seem broken - I got two of them on top of each other every time, and only one can transfer its value to the underlying TextField. I didn't design that feature, and have no idea when it's supposed to activate when not. Well - idea yes - when it thinks it can't scroll the text control into view? Then you'd need a tiny screen size setting and the android virtual keyboard to take up lots of space...

As for toasts, I saw that on hardware only. AVD's are fine. Readable Toasts, too, have some white/ light gray transparent box shifted a bit relative to their usual dark blue background, that may be a hint.

SomeTroglodyte avatar Mar 04 '24 12:03 SomeTroglodyte

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 15 days.

github-actions[bot] avatar Jun 03 '24 03:06 github-actions[bot]

This issue was closed because it has been stalled for 5 days with no activity.

github-actions[bot] avatar Jun 18 '24 03:06 github-actions[bot]