Unciv
Unciv copied to clipboard
Nullifies tile stats unique does not work for tile improvements
I know this issue could be in #3242 , but have to list it separately to demonstrate my urgency. This request stems from the "CoeHarMod" mod I developed, specifically in the section regarding districts. In Civilization VI, districts should cover all outputs of the tile they are on, while only retaining the outputs provided by the region itself. It is difficult to achieve this functionality with the existing uniques (or, to be more precise, it would require hundreds of lines of uniques to achieve a mediocre result). Therefore, I strongly urge the addition of these unique features specifically targeting improvements. Thanks a lot!
Doesn't Nullifies all other stats this tile provides
work?
This unique means that nullifiy other stats it provides. If it applies to Farm, it clears Production, Gold and so on except Food.(I want to clear all stats from Terrain, Feature Terrain and Resource, not only Food but also other stats) It is not same as that unique title says.
That's what the nullify unique does, sets tile stats to 0 If not that's a bug and please share
A little technical: The implementation is here - and says when it is encountered on a terrain - all yields of underlying terrain are forgotten and the stats of that terrain are final for the terrain-based yields of that tile (the bottom-most terrain wins if more than one have the Unique on that tile - I'm doubting a tiny little bit that is correct - so Fallout on top of a NullifyYields terrain that has yields itself won't nullify those - needs test).
That concens Terrain only, and all other contributions are unaffected and applied in the next step - improvements, resources, rivers (hey zero moddability here - maybe we should, maybe solve the lacking Pedia entry for them too), city-local uniques StatsFromTiles+StatsFromObject+StatsFromTilesWithout, EnsureMinimumStats, and percentage modifiers.
I had no idea what @AutumnPizazz meant by this a few moments ago before I checked the code - but now I think it clicked: "from the improvement" in the title - so they want a NullifyYields working on an improvement. Right? What about the other factors I listed - should they apply before and be nullified or after and add on top? I'd guess StatsFromTiles&co should be nullified but relative Stats modifers should apply? Rivers and resources - throw dice?
Sorry that there's a significant exam for me yesterday so it delayed some time.
That's what the nullify unique does, sets tile stats to 0 If not that's a bug and please share
Yeah, there's some test.
As for "Only retain the outputs from the improvement on the tile", I wish it to remove the basic 2 Food and only remain 1 Food from Farm Improvement.
This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 15 days.
I'll actually mark as not stale, but man, this title is bugging me as it makes it non obvious what is going on