Yair Even Or comments

Results 423 comments of


                                            Yair Even Or

Unreliable off() event handling

Good to hear it was resolved :) anyway, you can place safeguards in the backend instead of the frontend to bulletproof this

Add handling of big texts

We at my company also have a terrible experience with this package when rendering big diffs. > I've tested this with text up to 10MB recently The size is not...

Add handling of big texts

I will replace this library with a much better one I've found: https://github.com/MrWangJustToDo/git-diff-view

Tabulation in dropdown makes tagify fail

Thank you for the detailed analysis! The fix should be done in Tagify's source code though. I will work on it.

Tabulation in dropdown makes tagify fail

BTW, this is the correct way to use Tagify with objects in the `whitelist`: ```js var tagify = new Tagify(input, { tagTextProp: "name", dropdown: { enabled: 0, includeSelectedTags: true, mapValueTo:...

Delete key, focus/blur and dropdown improvements for select mode with userInput

I need videos showcasing the things these changes are trying to solve.. I do not understand from the description what exactly is the situation for each of your changes and...

Delete key, focus/blur and dropdown improvements for select mode with userInput

Hi, I cannot reproduce much of your videos because I don't know your exact Tagify configurations, so I cannot personally confirm the issues. Can you please share it here?

Delete key, focus/blur and dropdown improvements for select mode with userInput

Sorry I am too slow to respond to your well-done detective work! Never did I have any contributor as eager as you are. I work a very demanding full-time job...

Thanks, now at demo page svg images are visible, but it still do not have autocomplete and when you select smething it do not appear as tag until you write exactly same text and then hit double enter.

if you start typing `cz` you must apply the auto-complete, which is only a suggestion and doesn't actually changes your input until you press the `Right-Arrow` or `Tab` key. Also,...

fix(parts): fix press enter to break line before a tag in mixed mode

Thanks! I need to look at this more because I now see these lines: https://github.com/yairEO/tagify/pull/1458/files#diff-3c4c0fff34c73a26f550ccf4ba326621e9651dad00c41c373f6abf384944cf8dR476-R478 And I think there is some logic in your new `fixCaretBeforeTag` function which already exists...