serialize-javascript icon indicating copy to clipboard operation
serialize-javascript copied to clipboard

Add support for Error object (#135)

Open SidStraw opened this issue 3 years ago • 4 comments

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Add support for Error object to fixes #135

SidStraw avatar Dec 16 '21 17:12 SidStraw

Looks good to me

etienne-martin avatar Feb 25 '22 19:02 etienne-martin

Hey guys, Any idea why this hasn't been merged?

@SidStraw This change is helpful but it doesnt retain the trace of error, it would be amazing to retain the trace of error after deserialization.

oceanwap avatar May 09 '23 08:05 oceanwap

Thank you, this suggestion was very helpful. This is indeed the part that I did not handle. I will add this logic.

SidStraw avatar May 09 '23 16:05 SidStraw

@SidStraw if this is still needed, it will need to rebased since the code has changed since you originally opened this.

@okuryu thoughts on adding this in?

redonkulus avatar Jan 09 '24 00:01 redonkulus