kubectl-flame icon indicating copy to clipboard operation
kubectl-flame copied to clipboard
verified publisher icon yahoo

feat: Support macOS arm64

Open mandrean opened this issue 2 years ago • 4 comments

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Summary

This PR adds support for darwin/macOS arm64 users. Closes #74 and maybe others.

Description

I tried cross-compiling kubectl-flame with goreleaser on my M1 Mac, but got a compilation error for the darwin-arm64 binary: image

With x/sys bumped it now compiles just fine for darwin-arm64 as well:

image

Which means that the goreleaser GHA action will be able to build & release for that target arch as well, so the .krew.yaml can be updated with the new platform support.

mandrean avatar Mar 02 '23 13:03 mandrean

This works on my machine™

TYVM

Tombar avatar Mar 21 '23 19:03 Tombar

Hi @edeNFed! Could you review this?

mandrean avatar Mar 24 '23 14:03 mandrean

Dear yahoo, any chances to merge it and realease? Or should we drive our forks and release processes to have it?

mwos-sl avatar Mar 28 '23 14:03 mwos-sl

I second this. An ARM64 version would be nice.

kinoute avatar May 08 '23 06:05 kinoute