kubectl-flame icon indicating copy to clipboard operation
kubectl-flame copied to clipboard

feat: upgrade to async-profiler 2

Open loicmathieu opened this issue 4 years ago • 7 comments

Fixes #62

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

loicmathieu avatar Oct 19 '21 13:10 loicmathieu

@edeNFed I try to update to async profiler 2 using the released artifact but I don't know exactly how to test it. I successfully build the images and the different cli but I don't know how to package them as a kubectl plugin, or at least test them in another way.

loicmathieu avatar Oct 19 '21 13:10 loicmathieu

Can you share how you compiled the code? I used go build cli/main.go but ended up getting stuck with Launching profiler ... when using the tool.

BasselAshi avatar Feb 01 '22 00:02 BasselAshi

Hi @BasselAshi I use go build too to compile the code but as said I have no idea how to test it so I didn't run it.

loicmathieu avatar Feb 01 '22 08:02 loicmathieu

Hi @loicmathieu You can test this by using the --image flag. Simply upload your custom image to some registry and then invoke your compiled cli with: ./kubectl-flame --lang java <pod-name> -t 10s --image <image-name>

edeNFed avatar Feb 04 '22 08:02 edeNFed

Thanks @edeNFed I'll have a look next week

loicmathieu avatar Feb 04 '22 09:02 loicmathieu

@loicmathieu Is there any progress so far?

pvorb avatar Jun 09 '22 09:06 pvorb

@pvorb no, I didn't find the time to work on it yet.

loicmathieu avatar Jun 09 '22 09:06 loicmathieu