elide icon indicating copy to clipboard operation
elide copied to clipboard

Fix id type wrong due to no sorted methods from Class.getMethods

Open hugogu opened this issue 7 years ago • 5 comments

The Class.getMethods returns undetermined ordering in OpenJDK which may break the idType.

hugogu avatar Jan 31 '18 01:01 hugogu

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:

yahoocla avatar Jan 31 '18 01:01 yahoocla

@clayreimann @DennisMcWherter ,

Thank you all for the review comments. It sounds like there is a more appropriate way to achieve the same purpose. I'll do some more investigation as per your suggestions and get back with more details.

Hugo

hugogu avatar Feb 01 '18 16:02 hugogu

Thanks! Looking forward to seeing the update! :)

DennisMcWherter avatar Feb 02 '18 16:02 DennisMcWherter

1:When MyEntity.class extend AbstractPersistable . This problem while reshow. 2:Because EntityBinding source code cls.getMethods() while get two getId() Methods,have the some ’AnnotationPresent(Id.class)‘,but One is the interface Persistable<T>‘s Method and return Type is Obejct。 3:May be have better method ?

zhangzhenhuajack avatar Feb 03 '18 09:02 zhangzhenhuajack

Could you provide a small project that highlights this issue? That way we can experiment and write tests to ensure we don’t break this use case in the future.

clayreimann avatar Feb 03 '18 14:02 clayreimann